-
Notifications
You must be signed in to change notification settings - Fork 204
SG-40980 Simplify Azure Pipeline CI pipeline #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR simplifies the Azure Pipelines CI configuration by introducing parameterized loops to reduce code duplication. Instead of explicitly defining separate job templates for each OS, the pipeline now uses parameters to dynamically generate jobs for all combinations of operating systems and Python versions.
Key Changes:
- Introduced
python_versionsandos_versionsparameters to define test matrix configurations - Replaced explicit job template calls with nested loops that generate jobs dynamically
- Updated the
run-tests.ymltemplate to accept Python version as a parameter and removed the strategy matrix
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| azure-pipelines.yml | Added parameters for Python and OS versions, replaced explicit job templates with nested loops to generate test jobs dynamically |
| azure-pipelines-templates/run-tests.yml | Added python_version parameter, removed strategy matrix, converted OS name comparison to vm_image prefix checks, standardized task syntax to Bash@3 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…plify-ci-pipeline
Simplify the os_version/python_version combination for calling the test template.
No longer use a matrix strategy because only work with one dimension.
Define and use parameter for each version dimension and use the each operator for looping over both parameters.
Replicated changes on multiple repositories